Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base image to Debian 12 #457

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

MarkoBarisic
Copy link
Contributor

@MarkoBarisic MarkoBarisic commented Mar 29, 2024

Description

Problem

We need to upgrade from debian-11 to debian-12 to accommodate memgraph binaries built with toolchain v5.
debian-12 uses some different libs, most noticeably python-3.11.
This bump in python version (3.9 -> 3.11) is a bit tricky because we hardcoded all dependency versions and now some of them aren't supported by python-3.11.
First example is pytorch, we are using 1.12, but 3.11 supports 1.13 and up.

Solution

This PR introduces changes in build environment which are needed to correctly build mage images with memgraph built with toolchain v5.

  • update Dockerfiles
    • Dockerfile
    • Dockerfile.release
    • Dockerfile.no_ML
    • Dockerfile.cugraph
  • update workflows
    • test.yml
    • test_no_ml.yml
    • docker_publish.yml
  • update dependecies
    • python/requirements.txt
    • python/requirements_no_ML.txt
    • python/tests/requirements.txt

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone

Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MarkoBarisic
Copy link
Contributor Author

I tried removing versions from requirement files so that pip pulls the latest versions.
We can revert this

@MarkoBarisic MarkoBarisic modified the milestones: 1.16.0, 1.17.0 Apr 3, 2024
@MarkoBarisic MarkoBarisic changed the title Update repo for toolchain v5 Update base image to Debian 12 Apr 3, 2024
@gitbuda gitbuda removed this from the 1.17.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants